use packaged "opencv" from OS #21
Conversation
previously, opencv-2.4.9 was downloaded and compiled from source. now use the precompiled, package version from the OS. this comes in:
Debian Testing (Jessie): 2.4.9
Debian Stable (Wheezy): 2.3.1 # quite old. but is Wheezy still supported? boostrap.sh fails unmodified
Ubuntu 14.04 (Trusty): 2.4.8
Ubuntu 12.04 (Precise): 2.3.1 # not supported anymore?
there are more OS in the osdeps-file, where I just assume they bring similar packaged versions.
tested "image_processing/{frame_helper,stereo} in Jessie and Trusty. but obviously that shouldn't be it. which packages else?
Signed-off-by: Martin Zenzes <[email protected]>
marvin2k
force-pushed
the
precompiled_opencv
branch
from
546fe5c to
cfb3d7e
Compare
|
The idea of having extern/opencv was to be able to use newer version than the OS is providing (OpenCV 3.0 Beta for example). The best way would be therefore to track the git. But because of compatibly reasons some people refused to switch from archive to git. Therefore, I would also vote for removing it all together because right now you cannot even overwrite external/opencv with a git in your local installation without changing the package set. 👍 |
|
Is this still valid? |
At the time, a significant number of rock installs were building opencv "by hand" because older ubuntu versions only had very old opencv versions. The problem with changing archive to git then was that it would break "autoproj update" for all of them. @D-Alex: why would you have to modify the package set ? (as opposed to using an override ?) |
|
The last time I tried it was not possible to overwrite a tar with a git repository via overwrite.yml and I had to modify the package set |
|
Seems like an issue with autoproj then. |
|
Just tried it. It works as expected: the importer is updated to be a git importer, but import fails because the current checkout is not a git repository |
|
So could you merge this request to get the bootstrapping working until the importer issue is fixed? |
|
Sorry I missed something: how does this affect bootstrapping ? |
|
Because the Debian definition points to the opencv source archive, inside this, the folder name changed: #19 so bootstrapping with a package set with a opencv dependency just fails. As the apt-get package from debian has the same version, this PR is favorable over #19 This is not something exactly what should happen for a "supported OS", when "using it on a supported OS" can be broken vor over 2 months |
Debian is not officially supported, so take a deep breath here. There are basically two problems at hand:
Given that, removing the build-from-source definition is throwing the baby with the bathwater. Next time someone wants to build from source, he'll have to redo the work. I've cherry-picked and pushed the osdep commit. I would welcome changing the opencv source definition to use the git checkout (as suggested by @marvin2k) if someone is willing to do it, or I'll do it later on. |
previously, opencv-2.4.9 was downloaded and compiled from source. now use the precompiled, package version from the OS. this comes in:
Debian Testing (Jessie): 2.4.9
Debian Stable (Wheezy): 2.3.1 # quite old. Is Wheezy still supported? boostrap.sh fails if unmodified (
--no-check-certificate)Ubuntu 14.04 (Trusty): 2.4.8
Ubuntu 12.04 (Precise): 2.3.1 # 12.04 is not supported anymore?
there are more OS in the osdeps-file, where I just assume they bring similar packaged versions.
tested "image_processing/{frame_helper,stereo} in Jessie and Trusty. but obviously that shouldn't be it. which packages else?
Signed-off-by: Martin Zenzes [email protected]